Review Request: Plasmate: when "Enable signing plasmoid" is enabled, automatically choose a key

[Aaron J. Seigo]

> On May 28, 2012, 1:09 p.m., Aaron J. Seigo wrote:
> > given that this is a security feature, this looks a little too dangerous and lose.
> > 
> > instead, disable the signing button altogether until there is at least one key selected.
> 
> Giorgos Tsiapaliwkas wrote:
>     I don't understand In which widget you are referring. 
>     Do you mean the "Enable signing plasmoid" radiobutton?
>

there are a number of ways of doing this. in fact, thinking about it: i'd get rid of the "Enable signing" checkbox altogether. always make the signing UI enabled and if a key is selected, use that key. to allow selecting a key and then going back to "no signing" perhaps have a "No signing key" entry at the top of the key entry area. makes the whole thing a lot easier and gets rid of one more widget (the checkbox) in an already pretty busy window


- Aaron J.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105074/#review14229
-----------------------------------------------------------


On May 28, 2012, 8:01 a.m., Giorgos Tsiapaliwkas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105074/
> -----------------------------------------------------------
> 
> (Updated May 28, 2012, 8:01 a.m.)
> 
> 
> Review request for Plasma, Sebastian Kügler and Aaron J. Seigo.
> 
> 
> Description
> -------
> 
> Hello,
> 
> right now when "Enable signing plasmoid" is enabled if the user doesn't choose a gpg key,
> plasmate won't have a key enabled. So "Enable signing plasmoid", will be enabled but no signing will
> happen. 
> 
> How to test the issue,
> - rm ${KDEHOME}/share/config/plasmaterc
> -create a gpg key(gpg --gen-key)
> -open plasmate
> -click publisher
> -click enable
> 
> 
> Diffs
> -----
> 
>   publisher/signingwidget.cpp e63dbbd 
> 
> Diff: http://git.reviewboard.kde.org/r/105074/diff/
> 
> 
> Testing
> -------
> 
> It works.
> 
> 
> Thanks,
> 
> Giorgos Tsiapaliwkas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120529/2291c948/attachment-0001.html>