Review Request: Plasmate: port Publisher to a ui file and add an install action

[Aaron J. Seigo]

> On May 27, 2012, 6:43 p.m., Aaron J. Seigo wrote:
> > is the "testing done" comment about doPublish being called still correct? i don't see how it could be? :)
> 
> Giorgos Tsiapaliwkas wrote:
>     > i don't see how it could be? :)
>     
>     You have right it doesn't. That's my fault.
>     I just noticed that in the publish dialog that I had enabled the "Enable Signing Plasmoid".
>     So when the doPlasmaPkg was called the singing dialog was also called.
>     
>     So the patch is fine. Should I commit it?
>     
>     P.S.: I still need a shortcut for the install action. What do you want me to put there?

it does't require a shortcut; though Ctrl+I seems sane to me...


- Aaron J.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105031/#review14211
-----------------------------------------------------------


On May 24, 2012, 5:31 p.m., Giorgos Tsiapaliwkas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105031/
> -----------------------------------------------------------
> 
> (Updated May 24, 2012, 5:31 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Hello,
> 
> I ported Publisher to a ui file and I added an install action as sebas proposed.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 7e1bf4b 
>   mainwindow.h bd4d376 
>   mainwindow.cpp 4728894 
>   plasmateui.rc 9123298 
>   publisher/publisher.h ee57cf3 
>   publisher/publisher.cpp 11ddf36 
> 
> Diff: http://git.reviewboard.kde.org/r/105031/diff/
> 
> 
> Testing
> -------
> 
> When I active the install project action the Publisher::doPublish() is called.
> This mustn't happen.
> 
> Also I am don't know which shortcut to choose.
> 
> 
> Thanks,
> 
> Giorgos Tsiapaliwkas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120528/61fbf00c/attachment.html>