Review Request: SortFilterModel: Do not reset model while changing the regexp

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105042/#review14228
-----------------------------------------------------------

Ship it!


If i remember correctly it was a workaround to an old upstream problem of early qml.
i tested the patch a bit and seems to not cause issues

- Marco Martin


On May 25, 2012, 2:40 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105042/
> -----------------------------------------------------------
> 
> (Updated May 25, 2012, 2:40 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> SortFilterModel::setRegExp() calls beginResetModel() before setting the regexp and endResetModel() when done. This cause flickering as the QML view must refresh its entire content. QSortFilterProxyModel correctly add or remove rows when filtering, so resetting the model is not necessary.
> 
> 
> Diffs
> -----
> 
>   plasma/declarativeimports/core/datamodel.cpp 97d129e 
> 
> Diff: http://git.reviewboard.kde.org/r/105042/diff/
> 
> 
> Testing
> -------
> 
> Test script attached demonstrates the problem by having a delegate whose opacity goes from 0 to 1 when completed.
> 
> - Download regexp-flicker.{pro,cpp,qml}
> - run qmake ; make
> - Type in the input field => without the patch, remaining items flicker. With the patch they do not because they are not recreated.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120528/e20e3853/attachment.html>