Review Request: Blur tooltip backgrounds from system settings.
Ben Cooksley
bcooksley at kde.org
Sat May 26 21:16:16 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105060/#review14196
-----------------------------------------------------------
Ship it!
I can't see anything wrong with this, please commit it.
However, I do wonder if a dependency on Plasma for such a small amount of functionality is useful (perhaps the whole Tooltip should be ported over maybe)
- Ben Cooksley
On May 26, 2012, 1:44 p.m., Mark Gaiser wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105060/
> -----------------------------------------------------------
>
> (Updated May 26, 2012, 1:44 p.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> Tooltips from system settings are not blurred. This makes them blurred.
> As for the above groups, why isn't there a kde-workspace?
>
>
> Diffs
> -----
>
> systemsettings/app/CMakeLists.txt c6546bf
> systemsettings/app/ToolTips/ktooltipwindow.cpp 133e825
> systemsettings/app/ToolTips/ktooltipwindow_p.h 0813e6a
>
> Diff: http://git.reviewboard.kde.org/r/105060/diff/
>
>
> Testing
> -------
>
> Tested it on 4.8. Works and looks nice. I only compile tested it in master.
>
>
> Thanks,
>
> Mark Gaiser
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120526/4d111071/attachment.html>
More information about the Plasma-devel
mailing list