Review Request: Plasmate: Add Tabbox support to the startpage

[Martin Gräßlin]

> On May 24, 2012, 6:46 a.m., Martin Gräßlin wrote:
> >
> 
> Antonis Tsiapaliokas wrote:
>     There is still a big issue here.
>     
>     The template of the tabbox that i have put is located in the kde-workspace/kwin/kcmkwin/kwintabbox/qml/main.qml. The main.qml cannot be installed becuase it uses some Q_PROPERTY elements. Any ideas about how to fix that?
>     
>     Also i will update my diff, but for a quicker review please look at my comments :)

I don't understand what you mean with the Q_PROPERTY elements and what exactly you want to install.


> On May 24, 2012, 6:46 a.m., Martin Gräßlin wrote:
> > startpage.cpp, line 146
> > <http://git.reviewboard.kde.org/r/105011/diff/1/?file=65127#file65127line146>
> >
> >     I would use a kwin icon for TabBox and I think TabBox is a really, really bad name.
> >     
> >     I tend to call it "Window Switcher", the KCM is called "Task Switcher"
> 
> Antonis Tsiapaliokas wrote:
>     I have change the "Tabbox" to "Window Switcher".
>     
>     As regards the icon, i am sorry for that but  i have not change it because i have an issue with my kde environmnet and i cannot open a new KDE session.

I don't understand why you need a kde environment to set the right icon. All the infos are there in your source folder. Just look what the Window Switching KCM uses as an icon in the desktop file...


> On May 24, 2012, 6:46 a.m., Martin Gräßlin wrote:
> > startpage.cpp, line 332
> > <http://git.reviewboard.kde.org/r/105011/diff/1/?file=65127#file65127line332>
> >
> >     be aware of correct writing: KWin/TabBox would be the way it is called inside KWin.
> 
> Antonis Tsiapaliokas wrote:
>     I have change it to "Kwin/WindowSwitcher"...

be aware that it's KWin and not Kwin.


> On May 24, 2012, 6:46 a.m., Martin Gräßlin wrote:
> > templates/mainTabbox.qml, line 5
> > <http://git.reviewboard.kde.org/r/105011/diff/1/?file=65129#file65129line5>
> >
> >     you should fill in the copyright :-)
> 
> Antonis Tsiapaliokas wrote:
>     On startpage.cpp:466 we replacing the $AUTHOR and the $EMAIL with the real values which they have been provided by the user.

ah so that should be a template? In that case you picked the wrong file for a template. This is the file used by KWin to include the layouts, but nothing for a template. You would have to look at the various window switchers to extract the template.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105011/#review14107
-----------------------------------------------------------


On May 24, 2012, 1:17 p.m., Antonis Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105011/
> -----------------------------------------------------------
> 
> (Updated May 24, 2012, 1:17 p.m.)
> 
> 
> Review request for kwin, Plasma and Martin Gräßlin.
> 
> 
> Description
> -------
> 
> Hello,
> 
> This is the first task of my GSoC. I have add the tabbox support to the startpage of the plasmate.
> 
> NOTES:
> 
> 1)The service type of the tabbox is "Kwin/Tabbox,Plasma/Applet", because the Plasma::PackageStructure requires the "Plasma/Applet" in order to be able to be used. Also the plasmapkg and the plasmoidview require the "Plasma/Applet" service type.
> 2)Some lines doesn't have any differences because i have remove some whitespaces and "tabs"... 
> 
> ISSUES:
> 
> 1)The icons for the tabbox are wrong. I have some issues with my PCs and i cannot open a new session of the KDE.
> So i wasn't able to find the icon. Sorry for that.
> 2)The template of the tabbox that i have put is located in the kde-workspace/kwin/kcmkwin/kwintabbox/qml/main.qml. The main.qml cannot be installed becuase it uses some Q_PROPERTY elements. Any ideas about how to fix that?
> 3)I think that the starting comments of the tabbox should become better. I would prefer something like the "mainPlasmoid.qml"....
> 
> 
> Diffs
> -----
> 
>   editors/editpage.cpp a331ae5 
>   editors/metadata/metadataeditor.cpp fce65fd 
>   startpage.h 0df4c21 
>   startpage.cpp 9774b48 
>   templates/CMakeLists.txt 6a82772 
> 
> Diff: http://git.reviewboard.kde.org/r/105011/diff/
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> 
>   http://git.reviewboard.kde.org/r/105011/s/574/
> 
> 
> Thanks,
> 
> Antonis Tsiapaliokas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120524/bc23294b/attachment-0001.html>