Review Request: Plasmate: fix publisher's combobox and doCMake slot

[Sebastian Kügler]

> On May 23, 2012, 6:36 p.m., Giorgos Tsiapaliwkas wrote:
> > A side note here.
> > Why publisher doesn't use a *.ui file?
> > 
> > I guess that the *.ui are the prefered way as it regards the QWidgets. No?
> > Do you want me to port the file into a *.ui file?

Yes, that would be good.


- Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104969/#review14091
-----------------------------------------------------------


On May 23, 2012, 6:25 p.m., Giorgos Tsiapaliwkas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104969/
> -----------------------------------------------------------
> 
> (Updated May 23, 2012, 6:25 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Hello,
> 
> those are some issues which plasmate's publisher has
> 
> problem 1: the publisher's combobox wasn't aware for the right slot. When currentIndex was emitted both slots(doPlasmaPkg and doCMake was called.) I fixed that.
> problem 2: publisher's cmake process was trying to install a projectName.plasmoid file and not projectPath/CMakeLists.txt. I fixed that.
> problem 3: when the cmake slot is called, cmake creates the known temporary files in directory like ~/.kde4/share/apps/plasmate/projectName. I haven't fixed that.
> How can I change the current directory with Qt?
> 
> 
> Diffs
> -----
> 
>   publisher/publisher.h 6eba693 
>   publisher/publisher.cpp 3fcd268 
>   templates/cmakelists c3e2ce9 
> 
> Diff: http://git.reviewboard.kde.org/r/104969/diff/
> 
> 
> Testing
> -------
> 
> WIP
> 
> 
> Thanks,
> 
> Giorgos Tsiapaliwkas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120524/e7d95925/attachment.html>