Review Request: qml port of showActivityManager (it's just an icon)

Commit Hook null at kde.org
Thu May 24 09:41:08 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104959/#review14116
-----------------------------------------------------------


This review has been submitted with commit 51924c2f35063e0b0cc9446224c22465bd72d4f9 by Gregor Tätzner to branch master.

- Commit Hook


On May 21, 2012, 6:46 p.m., Greg T wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104959/
> -----------------------------------------------------------
> 
> (Updated May 21, 2012, 6:46 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Hello, I've played around a bit with the new qml stuff. Basically this port works the same way as the c++ version. Though the icon doesn't glow on mouse hover. How can I fix that?
> 
> 
> Diffs
> -----
> 
>   plasma/desktop/applets/CMakeLists.txt 731c70c 
>   plasma/desktop/applets/showActivityManager/CMakeLists.txt 592f38f 
>   plasma/desktop/applets/showActivityManager/Messages.sh 0f07ff5 
>   plasma/desktop/applets/showActivityManager/package/contents/ui/main.qml PRE-CREATION 
>   plasma/desktop/applets/showActivityManager/package/metadata.desktop PRE-CREATION 
>   plasma/desktop/applets/showActivityManager/plasma-applet-org.kde.showActivityManager.desktop 98e9bd6 
>   plasma/desktop/applets/showActivityManager/showActivityManager.h f58fbb7 
>   plasma/desktop/applets/showActivityManager/showActivityManager.cpp e77df0d 
>   plasma/generic/dataengines/activities/activities.operations f9ce034 
>   plasma/generic/dataengines/activities/activityjob.cpp 7fe8823 
> 
> Diff: http://git.reviewboard.kde.org/r/104959/diff/
> 
> 
> Testing
> -------
> 
> click: activity manager comes up
> click again: manager vanishes!
> 
> 
> Thanks,
> 
> Greg T
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120524/0e33633f/attachment.html>


More information about the Plasma-devel mailing list