Review Request: Plasmate: fix publisher's combobox and doCMake slot

Giorgos Tsiapaliwkas terietor at gmail.com
Wed May 23 18:25:09 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104969/
-----------------------------------------------------------

(Updated May 23, 2012, 6:25 p.m.)


Review request for Plasma.


Changes
-------

Update the diff.

This diff DOESN'T contain sebas suggestion
I will update the diff according to sebas if everyone is ok.


Description
-------

Hello,

those are some issues which plasmate's publisher has

problem 1: the publisher's combobox wasn't aware for the right slot. When currentIndex was emitted both slots(doPlasmaPkg and doCMake was called.) I fixed that.
problem 2: publisher's cmake process was trying to install a projectName.plasmoid file and not projectPath/CMakeLists.txt. I fixed that.
problem 3: when the cmake slot is called, cmake creates the known temporary files in directory like ~/.kde4/share/apps/plasmate/projectName. I haven't fixed that.
How can I change the current directory with Qt?


Diffs (updated)
-----

  publisher/publisher.h 6eba693 
  publisher/publisher.cpp 3fcd268 
  templates/cmakelists c3e2ce9 

Diff: http://git.reviewboard.kde.org/r/104969/diff/


Testing
-------

WIP


Thanks,

Giorgos Tsiapaliwkas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120523/bdc53a13/attachment.html>


More information about the Plasma-devel mailing list