Review Request: Use Config to Provide Activity Icons

[Ivan Čukić]

> On May 22, 2012, 12:52 p.m., Aaron J. Seigo wrote:
> > "nepomuk works differently" should not be a reason for this particular change.
> > 
> > the question is whether to store the icons in nepomuk or not. if they are stored in nepomuk, then the information stays with the activities. if they are stored outside of nepomuk, then when we want to do things like migrate activities it becomes messier and we lose visibility on the connection between the image and the activity.
> 
> David Narváez wrote:
>     This review request has nothing to do with storing icons in Nepomuk or not. It has to do with what is returned to a client when it requests an icon for an activity - if we wait for Nepomuk to start and then return the icon there or just use the config file which already has the info. Icons are still stored in Nepomuk and sync'ed later in the code once Nepomuk is available.
> 
> Aaron J. Seigo wrote:
>     let me rephrase for clarity: storing activity data (esp duplicate data) outside of nepomuk all to work around annoyances (like the one your patch addresses) or to placate people who insist they won't enable nepomuk makes no sense at this point.
>     
>     it would be far more sensible to ensure that this data is consistently and quickly available from nepomuk than keeping another cache of this information outside of nepomuk.
> 
> David Narváez wrote:
>     libkactivities' master has moved far into the direction of caching the info in the config while syncing with Nepomuk when available. The behavior proposed in this patch is actually sort of a backport of master's behavior.
>     
>     I, on the other hand, tried my best to depend on Nepomuk to get the info but there seems to be no reliable way of getting the info in every possible case without at least breaking the ABI - not to mention anything about "quickly". I could elaborate but I don't know if this is the best place to do so.

I don't know how important this is for 4.8 when we are approaching the next release.

----

Data duplication in this case is not necessarily a bad thing.

Nepomuk is a rather nice tool for sharing data to other applications. It is not that nice when managing the internal data is concerned. So, in a manner of speaking, the config file is not the cache - it *is* the data. Stuff in Nepomuk is the export of the data to the public.

I know you had the idea of kamd becoming a nepomuk service so that we could skip some of the indirections that currently exist. It wouldn't change a thing - there is really no difference between a nepomuk service and any other process using nepomuk apart from the way they are started. No speed improvements, everything goes via d-bus, and graph-database is as slow as any other graph database etc.

Abstractions for the things in a database would be needed as they are in any other system - so that we can control and know what goes in and out of the database, and don't need to create resource watchers (a problem that dolphin ppl are currently having, according to a thread on the ml) ...

But, all this should be in a separate discussion. Don't want to hog the review request.


- Ivan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105008/#review14047
-----------------------------------------------------------


On May 22, 2012, 3:12 a.m., David Narváez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105008/
> -----------------------------------------------------------
> 
> (Updated May 22, 2012, 3:12 a.m.)
> 
> 
> Review request for Plasma and Ivan Čukić.
> 
> 
> Description
> -------
> 
> Since we can't trust Nepomuk anymore now that ontologies are loaded asynchronously, we better implement the approach we have in master.
> 
> 
> This addresses bug 298684.
>     http://bugs.kde.org/show_bug.cgi?id=298684
> 
> 
> Diffs
> -----
> 
>   service/ActivityManager.cpp 8927c43 
>   service/ActivityManager_p.h 3ea1d8a 
> 
> Diff: http://git.reviewboard.kde.org/r/105008/diff/
> 
> 
> Testing
> -------
> 
> Log out and back in. Before this patch, icons would probably load later, or not load at all. Now icons are displayed right away when desktop is loaded.
> 
> 
> Thanks,
> 
> David Narváez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120522/8af5ba66/attachment.html>