Review Request: Avoid multiple map - engine connections

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105003/#review14021
-----------------------------------------------------------

Ship it!


code wise looks good, the code also looked it was causing multiple connections indeed

- Marco Martin


On May 21, 2012, 1:51 p.m., Jacopo De Simoi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105003/
> -----------------------------------------------------------
> 
> (Updated May 21, 2012, 1:51 p.m.)
> 
> 
> Review request for Plasma and Aaron J. Seigo.
> 
> 
> Description
> -------
> 
> This fixes some multiple connection issues; up to now we connect the map to the engine once for each device that is added, hence when some device changes its state, it triggers the corresponding signal in the map, which in turn triggers multiple times  the corresponding slot in the engine.
>  
> This seems to have been like that from ages. Was there a reason for that?
> 
> 
> Diffs
> -----
> 
>   plasma/generic/dataengines/soliddevice/devicesignalmapmanager.cpp 4549cd4 
> 
> Diff: http://git.reviewboard.kde.org/r/105003/diff/
> 
> 
> Testing
> -------
> 
> basic testing: everything works as expected.
> 
> 
> Thanks,
> 
> Jacopo De Simoi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120521/ba3e3768/attachment-0001.html>