Review Request: qml port of showActivityManager (it's just an icon)
Marco Martin
notmart at gmail.com
Sun May 20 19:34:53 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104959/#review13999
-----------------------------------------------------------
right, forgot about that ;)
yes, messages.sh has to be added before it can be merged.
- Marco Martin
On May 15, 2012, 7:02 p.m., Greg T wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104959/
> -----------------------------------------------------------
>
> (Updated May 15, 2012, 7:02 p.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> Hello, I've played around a bit with the new qml stuff. Basically this port works the same way as the c++ version. Though the icon doesn't glow on mouse hover. How can I fix that?
>
>
> Diffs
> -----
>
> plasma/desktop/applets/CMakeLists.txt 731c70c
> plasma/desktop/applets/showActivityManagerQml/CMakeLists.txt PRE-CREATION
> plasma/desktop/applets/showActivityManagerQml/activities.svgz PRE-CREATION
> plasma/desktop/applets/showActivityManagerQml/package/contents/ui/main.qml PRE-CREATION
> plasma/desktop/applets/showActivityManagerQml/package/metadata.desktop PRE-CREATION
> plasma/generic/dataengines/activities/activities.operations f9ce034
> plasma/generic/dataengines/activities/activityjob.cpp 7fe8823
>
> Diff: http://git.reviewboard.kde.org/r/104959/diff/
>
>
> Testing
> -------
>
> click: activity manager comes up
> click again: manager vanishes!
>
>
> Thanks,
>
> Greg T
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120520/03c11263/attachment-0001.html>
More information about the Plasma-devel
mailing list