Review Request: JJ bug 224062 - add switch user check to kickoff leave model
Brian LaRochelle
larochelle.brian at gmail.com
Wed May 16 03:05:12 UTC 2012
> On May 7, 2012, 3:54 p.m., Martin Gräßlin wrote:
> > please also put the commit in kickoff-qml branch as otherwise it's quite likely that it gets lost once I finish the QML port of kickoff
>
> Brian LaRochelle wrote:
> I can track the kickoff-qml branch, test, and attach a patch for that branch. If that is what you're asking, or was your comment directed at whoever may commit the patch?
>
> Martin Gräßlin wrote:
> yes that would be great if you could provide a patch for that branch.
>
> Brian LaRochelle wrote:
> will do. i wouldn't be able to get to it until after the weekend tho. thanks
attached file kickoff-qml.bug.224062.patch, for the kickoff-qml branch
- Brian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104879/#review13542
-----------------------------------------------------------
On May 7, 2012, 2:06 p.m., Brian LaRochelle wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104879/
> -----------------------------------------------------------
>
> (Updated May 7, 2012, 2:06 p.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> -modified kde-workspace/plasma/desktop/applets/kickoff/core/leavemodel.cpp, added check to KDisplayManager().isSwitchable()
> -Bug 224062
>
>
> This addresses bug https://bugs.kde.org/show_bug.cgi?id=224062.
> http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=224062
>
>
> Diffs
> -----
>
> plasma/desktop/applets/kickoff/core/leavemodel.cpp 31467ac
>
> Diff: http://git.reviewboard.kde.org/r/104879/diff/
>
>
> Testing
> -------
>
> Tested against kde master branch, in Xephyr nested session
>
>
> Thanks,
>
> Brian LaRochelle
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120516/6ea98291/attachment-0001.html>
More information about the Plasma-devel
mailing list