Review Request: [KActivityManagerDaemon] Activity Changed On Screen Display

[Kai Uwe Broulik]

> On May 7, 2012, 6:04 p.m., Ivan Čukić wrote:
> > I really don't like having this as a kamd plugin.
> > 
> > In general, I dream of a day when kamd will have no GUI code whatsoever.
> 
> Thomas Lübking wrote:
>     What about using knotify and extending it by an OSD?
> 
> makis marimpis wrote:
>     heh, that's why i thought it would be best to ask first.
>     it doesn't look good to me too, having gui code to a daemon.
> 
> Ivan Čukić wrote:
>     @Thomas Having a standard OSD would be awesome, a natural extension of notifications we introduced with 4.x.

This OSD could/should also be able to draw meters, so we can obsolete the repeated implementation of the former, in e.g. KMix volume OSD, Solid brightness OSD, etc etc


- Kai Uwe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104603/#review13552
-----------------------------------------------------------


On May 7, 2012, 5:49 p.m., makis marimpis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104603/
> -----------------------------------------------------------
> 
> (Updated May 7, 2012, 5:49 p.m.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Description
> -------
> 
> Closes: http://bugs.kde.org/show_bug.cgi?id=265456
> Partialy closes: https://bugs.kde.org/show_bug.cgi?id=295410
> 
> "On screen display" notification when changing activities.
> Displays the user icon and the name.
> 
> It is heavily based on KWin's DesktopChangedOSD and KRunner's Quicksand.
> 
> This could be as well implemented on KWin, but i did as a kamd plugin for fun :P.
> 
> For the time being i think it is not correct to force such plugin (it would be cool is kamd's plugins were managed via systemsettings) without an option to enable/disable, but anyways, here goes nothing. Code cleanup is somewhat needed.
> 
> 
> This addresses bugs 265456 and 295410.
>     http://bugs.kde.org/show_bug.cgi?id=265456
>     http://bugs.kde.org/show_bug.cgi?id=295410
> 
> 
> Diffs
> -----
> 
>   service/plugins/CMakeLists.txt 3e965c0a201a7eee2c9868fcf163cf55af636858 
>   service/plugins/activitychangedosd/CMakeLists.txt PRE-CREATION 
>   service/plugins/activitychangedosd/activitychangeditem.h PRE-CREATION 
>   service/plugins/activitychangedosd/activitychangeditem.cpp PRE-CREATION 
>   service/plugins/activitychangedosd/activitychangedosd.h PRE-CREATION 
>   service/plugins/activitychangedosd/activitychangedosd.cpp PRE-CREATION 
>   service/plugins/activitychangedosd/activitychangedosdplugin.h PRE-CREATION 
>   service/plugins/activitychangedosd/activitychangedosdplugin.cpp PRE-CREATION 
>   service/plugins/activitychangedosd/activitymanager-plugin-activitychangedosd.desktop PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/104603/diff/
> 
> 
> Testing
> -------
> 
> Changed activities and it works.
> 
> 
> Screenshots
> -----------
> 
> without kwin effects
>   http://git.reviewboard.kde.org/r/104603/s/531/
> with kwin effects
>   http://git.reviewboard.kde.org/r/104603/s/532/
> after kwin effects disabledd (possible bug)
>   http://git.reviewboard.kde.org/r/104603/s/533/
> 
> 
> Thanks,
> 
> makis marimpis
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120507/170a7d48/attachment.html>