Review Request: [KActivityManagerDaemon] Activity Changed On Screen Display

[makis marimpis]

> On April 15, 2012, 9:10 a.m., Martin Gräßlin wrote:
> > FTR: KWin's desktop change OSD has been completely rewritten in QML and I would highly suggest that it should also this OSD should use QML.

i'll convert it to QML(in a totally different outlook), but was wondering whether to move it into KWin or keep it as a plugin... any thoughts? :-)


- makis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104603/#review12459
-----------------------------------------------------------


On May 7, 2012, 5:49 p.m., makis marimpis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104603/
> -----------------------------------------------------------
> 
> (Updated May 7, 2012, 5:49 p.m.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Description
> -------
> 
> Closes: http://bugs.kde.org/show_bug.cgi?id=265456
> Partialy closes: https://bugs.kde.org/show_bug.cgi?id=295410
> 
> "On screen display" notification when changing activities.
> Displays the user icon and the name.
> 
> It is heavily based on KWin's DesktopChangedOSD and KRunner's Quicksand.
> 
> This could be as well implemented on KWin, but i did as a kamd plugin for fun :P.
> 
> For the time being i think it is not correct to force such plugin (it would be cool is kamd's plugins were managed via systemsettings) without an option to enable/disable, but anyways, here goes nothing. Code cleanup is somewhat needed.
> 
> 
> This addresses bugs 265456 and 295410.
>     http://bugs.kde.org/show_bug.cgi?id=265456
>     http://bugs.kde.org/show_bug.cgi?id=295410
> 
> 
> Diffs
> -----
> 
>   service/plugins/CMakeLists.txt 3e965c0a201a7eee2c9868fcf163cf55af636858 
>   service/plugins/activitychangedosd/CMakeLists.txt PRE-CREATION 
>   service/plugins/activitychangedosd/activitychangeditem.h PRE-CREATION 
>   service/plugins/activitychangedosd/activitychangeditem.cpp PRE-CREATION 
>   service/plugins/activitychangedosd/activitychangedosd.h PRE-CREATION 
>   service/plugins/activitychangedosd/activitychangedosd.cpp PRE-CREATION 
>   service/plugins/activitychangedosd/activitychangedosdplugin.h PRE-CREATION 
>   service/plugins/activitychangedosd/activitychangedosdplugin.cpp PRE-CREATION 
>   service/plugins/activitychangedosd/activitymanager-plugin-activitychangedosd.desktop PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/104603/diff/
> 
> 
> Testing
> -------
> 
> Changed activities and it works.
> 
> 
> Screenshots
> -----------
> 
> without kwin effects
>   http://git.reviewboard.kde.org/r/104603/s/531/
> with kwin effects
>   http://git.reviewboard.kde.org/r/104603/s/532/
> after kwin effects disabledd (possible bug)
>   http://git.reviewboard.kde.org/r/104603/s/533/
> 
> 
> Thanks,
> 
> makis marimpis
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120507/620d3210/attachment-0001.html>