Review Request: Merge the branch KLocaleQMLBindings into master

[Giorgos Tsiapaliwkas]

On 30 April 2012 15:00, Sebastian Kügler <sebas at kde.org> wrote:

> On Sunday, April 29, 2012 20:12:23 Giorgos Tsiapaliwkas wrote:
> > > On April 29, 2012, 12:18 p.m., Marco Martin wrote:
> > > > yes, i think is to merge at this point.
> > > >
> > > >
> > > >
> > > > it can be only partial, but the api can map to qml only so much, so i
> > > > think is as far it can go.> >
> > > >
> > > >
> > > > to me, the only blocker so far(see below) is that doesn't depend from
> > > > plasma at all, so should be in the kde namespace
> > You haven't say your opinion about those,
> >
> > a. there is tests/contents/code/klocaleqmltest.qml I believe that it
> should
> > be tests/contents/ui/main.qml b. the test plasmoid is exported as
> > org.kde.klocaleqmltest it should be org.kde.example.localetest c.
> > Locale::setActiveCatalog and Locale::setMainCatalog since we didn't want
> > the bindings to influence the core functionality.
>
> Could you put the tests plasmoid under kde-runtime/declarative/tests/ ?
> That's
> where other test / examples are, so makes it easier to find.
>
> Thanks,
>

Sure, actually I have merged the branch yet. I will merge it tomorrow.
Can I convert the declarativeimports/test into a plasmoid???
If we make it a plasmoid it will be easier to use it.

-- 
Giorgos Tsiapaliwkas (terietor)
KDE Developer

terietor.gr
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120502/14816529/attachment.html>