Review Request: "New Desktop" in To Desktop menu

Martin Gräßlin kde at martin-graesslin.com
Tue May 1 18:04:40 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104781/#review13235
-----------------------------------------------------------



kwin/useractions.cpp
<http://git.reviewboard.kde.org/r/104781/#comment10365>

    looks like you forgot to use the getter



kwin/workspace.cpp
<http://git.reviewboard.kde.org/r/104781/#comment10361>

    const not const_cast :-)


- Martin Gräßlin


On May 1, 2012, 11:42 a.m., makis marimpis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104781/
> -----------------------------------------------------------
> 
> (Updated May 1, 2012, 11:42 a.m.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Description
> -------
> 
> I found http://community.kde.org/KWin/Ideas#.22New_Desktop.22_in_To_Desktop_menu and i thought i would be nice to have.
> Only a few lines of code.
> 
> 
> Diffs
> -----
> 
>   kwin/useractions.cpp 09e18c3d061f6521749ebfe2665e2db9099dad9f 
>   kwin/workspace.h 9df435cebba26bea107bbb0ef8859863abe0fb73 
>   kwin/workspace.cpp b5c801403d1b77cf8054a51b39271ab0de4c0efb 
>   libs/taskmanager/taskactions.cpp 7917c0d12511937e2ce0092720a82c1e99fcd6bd 
>   libs/taskmanager/taskactions_p.h 52eae0513e62c7dbb3066fc26cd290bada7d1479 
> 
> Diff: http://git.reviewboard.kde.org/r/104781/diff/
> 
> 
> Testing
> -------
> 
> Moved client to "New Desktop". Seems to work fine.
> 
> 
> Thanks,
> 
> makis marimpis
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120501/9691c335/attachment.html>


More information about the Plasma-devel mailing list