Review Request: GlobalShortcuts Plugin for ActivityManager (kamd)

[makis marimpis]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104428/
-----------------------------------------------------------

(Updated March 31, 2012, 7:48 p.m.)


Review request for KDE Base Apps, KDE Runtime, Plasma, and Ivan Čukić.


Changes
-------

Fixed all issues except from the usage of "QDBusReply", i not quite sure how to fix it.


Description
-------

(follows discarded review: 104391)

The plugin adds global keyboard shortcuts for changing the activity.
Defaults start from Qt::MetaModifier + Qt::Key_F1.

Initially, this functionality was implemented (without correct results) using KActitivities::Controller.
Using DBus seems fine, just that... it forces kamd to start with 3-4 seconds delay - so it really needs modification/and i would like more guidance related to dbus :D.
Other than that, feedback is needed. 


This addresses bugs 265069 and 273467.
    http://bugs.kde.org/show_bug.cgi?id=265069
    http://bugs.kde.org/show_bug.cgi?id=273467


Diffs (updated)
-----

  service/plugins/CMakeLists.txt 3e965c0a201a7eee2c9868fcf163cf55af636858 
  service/plugins/globalshortcuts/CMakeLists.txt PRE-CREATION 
  service/plugins/globalshortcuts/activitymanager-plugin-globalshortcuts.desktop PRE-CREATION 
  service/plugins/globalshortcuts/globalshortcuts.h PRE-CREATION 
  service/plugins/globalshortcuts/globalshortcuts.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/104428/diff/


Testing
-------

Logged in.
Used the default shortcuts to switch activities.
It works!


Thanks,

makis marimpis

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120331/dd2f55ae/attachment.html>