Review Request: Copy files instead of moving if parent dir is not writable

[Lamarque Vieira Souza]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104417/
-----------------------------------------------------------

(Updated March 29, 2012, 1:58 a.m.)


Review request for KDE Runtime and Plasma.


Changes
-------

QFileInfo does not work with urls like "file:///path/to/file", we must use "/path/to/file".

Only urls with scheme "file" can be moved now.

Owning a folder and not having permission to write to it is a bit suspecious, so let's allow
kio show the "permission denied dialog" when trying to move a file/folder in such situation.


Description
-------

When adding an application resource to a private activity kactivitymanager tries to move the resource's .desktop file to the activity's private folder. The new .desktop file is created successfully but the source file is not deleted if the user does not have write permission on the file's directory. This patch detects such situation and uses copy instead of move to prevent "permission denied" messages for every resource being added.


This addresses bug 296808.
    http://bugs.kde.org/show_bug.cgi?id=296808


Diffs (updated)
-----

  service/jobs/nepomuk/Move.h 8a8afd1 
  service/jobs/nepomuk/Move.cpp 08a3cc2 

Diff: http://git.reviewboard.kde.org/r/104417/diff/


Testing
-------

Works on Meego devel image. The file is copied and no error message is shown.


Thanks,

Lamarque Vieira Souza

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120329/3ffd7143/attachment-0001.html>