Review Request: KMix Declarative Applet - First attempt

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6928/#review10739
-----------------------------------------------------------


to me the blocker is mostly having to have kmix running...
since actual kmix would be (sill ;) needed for the actual complete ui... what about this?

a modification in the systray applet, that queries sycoca for offers of plasmoids that can manage a determined statusnotifier item, so it would ask for something providing KMix (better if the ksni id is renamed in org.kde.kmix) then will be the systray itself that either instantiates the kmix applet, or just doesn't show the kmix icon if the applet was explicitly created by the user.

idea is still a bit nebulous, did i explain myself enough? ;)

- Marco Martin


On March 28, 2012, 5:24 p.m., Diego Casella wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6928/
> -----------------------------------------------------------
> 
> (Updated March 28, 2012, 5:24 p.m.)
> 
> 
> Review request for Plasma, Aaron Seigo and Marco Martin.
> 
> 
> Description
> -------
> 
> First attempt of making a declarative kmix applet for plasma.
> What the apple does right now:
> * modifies the volume level and the mute/unmute status of the master channel;
> * reacts to changes of the volume level/status (i.e. made with multimedia keys);
> * disables the slider if the channel gets muted, and enables it back as soon as the channel gets unmuted;
> * collapses gracefully in a popup icon when placed inside the panel.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdemultimedia/kmix/plasma/CMakeLists.txt 1287513 
>   trunk/KDE/kdemultimedia/kmix/plasma/kmix-applet/contents/code/VerticalControl.qml PRE-CREATION 
>   trunk/KDE/kdemultimedia/kmix/plasma/kmix-applet/contents/code/kmixapplet.qml PRE-CREATION 
>   trunk/KDE/kdemultimedia/kmix/plasma/kmix-applet/metadata.desktop PRE-CREATION 
> 
> Diff: http://svn.reviewboard.kde.org/r/6928/diff/
> 
> 
> Testing
> -------
> 
> Tested against r1287510. For basic audio management it works great imho.
> 
> However, there is a lot of room for improvements, but this is gonna need some extra work outside the kmix applet scope:
> * first of all, the applet need kmix executable to run in order to perform the dbus calls. You can of course disable KMix tray icon feature but, at every login, KMix mainwindow will be shown and the user must closeby hand. This is a kind of ugly behavior that should be avoided;
> * it will be great to great to add an action to allow the user to select the master channel (by reusing KMix "Select Master Channel" widget), but this will require tweaking KMix dbus interface;
> * as you noticed in the screenshots, the applet in the panel and in the desktop have different size even if it __is__ actually the same: something is going wrong when plasma shows the PopupApplet. This behavior was even worse when I started implementing a "flip" action to change the layout from horizontal to vertical and vice-versa, and for this reason I gave up and simply stick with the vertical layout.
> 
> Could this applet be shipped in the current status, or should we wait for all the aforementioned improvements?
> Comments/ideas/suggestions?
> 
> Cheers :)
> 
> 
> Screenshots
> -----------
> 
> Applet look in panel and desktop
>   http://svn.reviewboard.kde.org/r/6928/s/627/
> Applet look in panel and desktop - audio muted
>   http://svn.reviewboard.kde.org/r/6928/s/628/
> 
> 
> Thanks,
> 
> Diego Casella
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120328/c9e8276b/attachment.html>