Review Request: Copy files instead of moving if parent dir is not writable
Lamarque Vieira Souza
lamarque at kde.org
Mon Mar 26 18:04:22 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104417/
-----------------------------------------------------------
Review request for KDE Runtime and Plasma.
Description
-------
When adding an application resource to a private activity kactivitymanager tries to move the resource's .desktop file to the activity's private folder. The new .desktop file is created successfully but the source file is not deleted if the user does not have write permission on the file's directory. This patch detects such situation and uses copy instead of move to prevent "permission denied" messages for every resource being added.
This addresses bug 296808.
http://bugs.kde.org/show_bug.cgi?id=296808
Diffs
-----
service/jobs/nepomuk/Move.h 8a8afd1
service/jobs/nepomuk/Move.cpp 08a3cc2
Diff: http://git.reviewboard.kde.org/r/104417/diff/
Testing
-------
Works on Meego devel image. The file is copied and no error message is shown.
Thanks,
Lamarque Vieira Souza
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120326/4475e4b3/attachment.html>
More information about the Plasma-devel
mailing list