Review Request: Add keyboard shortcuts to ActivityManager

[Ivan Čukić]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104391/#review11814
-----------------------------------------------------------


I don't think this is the right approach of dealing with the keyboard shortcuts for activities:

- not discoverable
- clashes with the filter bar (which is the only way to discover the feature)
- doesn't work in general case of user having more than 10 activities
- the user needs to open the activity bar, count the #number of the desired activity (the order can change), and then press the key.

I'd rather have it in kactivitymanagerd - to register global shortcuts, and that the user can set them in the system settings where the shortcuts for other programs are set.

- Ivan Čukić


On March 23, 2012, 7:35 p.m., makis marimpis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104391/
> -----------------------------------------------------------
> 
> (Updated March 23, 2012, 7:35 p.m.)
> 
> 
> Review request for Plasma and Ivan Čukić.
> 
> 
> Description
> -------
> 
> Adds keyboard shortcuts (0-9) for quick selecting an activity through ActivityManager plasma (Meta + Q).
> My main concern is how to focus to FilterBar; probably add a shortcut like "Ctr+S" via buddy system? (random thought).
> 
> 
> This addresses bugs 265069 and 273467.
>     http://bugs.kde.org/show_bug.cgi?id=265069
>     http://bugs.kde.org/show_bug.cgi?id=273467
> 
> 
> Diffs
> -----
> 
>   plasma/desktop/shell/activitymanager/activitylist.h 09ed686 
>   plasma/desktop/shell/activitymanager/activitylist.cpp 3327cdf 
>   plasma/desktop/shell/activitymanager/activitymanager.cpp 5aeaccf 
> 
> Diff: http://git.reviewboard.kde.org/r/104391/diff/
> 
> 
> Testing
> -------
> 
> Run ActivityManager and select and press a number.
> 
> 
> Thanks,
> 
> makis marimpis
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120324/ed06a73d/attachment.html>