Review Request: Scroll automatically when touching the border with the rubberband

[Ignat Semenov]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104396/
-----------------------------------------------------------

(Updated March 24, 2012, 12:42 p.m.)


Review request for Plasma, Aaron J. Seigo and Fredrik Höglund.


Changes
-------

Stop autoscrolling on lmb release with an active rubberband.


Description
-------

Wehn dragging a rubberband over an icon view with a scrollbar, scroll the view automatically on touching the border with the mouse during drag.

I've had to mod stopAutoScrolling() and call it in IconView::wheelEvent() and AbstractItemView::scrollBarActionTriggered() to allow the user to stop the automatic scrolling on those events.


This addresses bug 189350.
    http://bugs.kde.org/show_bug.cgi?id=189350


Diffs (updated)
-----

  plasma/applets/folderview/abstractitemview.cpp 3debb70 
  plasma/applets/folderview/iconview.h 0bd6dc0 
  plasma/applets/folderview/iconview.cpp 36e640b 

Diff: http://git.reviewboard.kde.org/r/104396/diff/


Testing
-------

Tested, works.

Maybe we should also stop automatic scrolling if the user releases the LMB while scrollling automatically as a result of dragging the rubberband over the view border? Fredrik, what do you think?


Thanks,

Ignat Semenov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120324/671b7cc9/attachment.html>