Review Request: Export WindowId on Plasma Dialog

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104393/#review11797
-----------------------------------------------------------

Ship it!


is quite specific, but dialog already messes with window properties a bit too much because wasn't really avoidable.

in the end the application of it is cool, and doesn't seem too dangerous, so +1

- Marco Martin


On March 24, 2012, 9:37 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104393/
> -----------------------------------------------------------
> 
> (Updated March 24, 2012, 9:37 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Adding a property to read the window Id of a Plasma Dialog.
> 
> Why do I need it? Well if I have a declarative KWin script and want to open a Plasma Dialog and then render a window thumbnail in the dialog I need the windowId to embedd the thumbnail on. See attachement for what is possible with that.
> 
> 
> Diffs
> -----
> 
>   plasma/declarativeimports/core/dialog.h 33ab07a 
>   plasma/declarativeimports/core/dialog.cpp 1d6c2ca 
> 
> Diff: http://git.reviewboard.kde.org/r/104393/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120324/7c60ba5c/attachment.html>