Review Request: Less repainting on mousePressEvent(), moseReleaseEvent() and mouseDoubleClickEvent() in FolderView::IconView

[Ignat Semenov]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103822/
-----------------------------------------------------------

(Updated March 22, 2012, 1:07 p.m.)


Review request for Plasma, Aaron J. Seigo and Marco Martin.


Changes
-------

Fixed a one-line issue where multiple selection would not be repainted with single-click settings.

In mouseReleaseEvent(), in the single click branch, we should not reset the selection as this will result in the code in the following if clause not being executed and the selection not repainted.

Now this is ready to go. Sorry for the delay, I'm cleaning up my old requests now, finally.


Description
-------

This patch aims to save some repaints in FolderView::IconView on the various mouseEvent()'s by choosing what to repaint in a bit smarter way.


Diffs (updated)
-----

  plasma/applets/folderview/iconview.h 12e93b3 
  plasma/applets/folderview/iconview.cpp 5c4e086 

Diff: http://git.reviewboard.kde.org/r/103822/diff/


Testing
-------

Testing done against master, seems to behave indentically.


Thanks,

Ignat Semenov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120322/b8da2db1/attachment.html>