Review Request: Add missing property alias "animation" in Slider Plasma Component
Marco Martin
notmart at gmail.com
Mon Mar 19 09:57:21 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104318/#review11611
-----------------------------------------------------------
actually it was removed and i did forget to remove it from the docs as well.
the rationale is that component users shouldn't be able to have a so fine grained control over the appearance otherwise components miss one of their main points that is enforcing consistency.
what would be cool is having all animations following a global on/off switch, even tough there isn't much infrastructure for it at the moment
- Marco Martin
On March 17, 2012, 7:27 p.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104318/
> -----------------------------------------------------------
>
> (Updated March 17, 2012, 7:27 p.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> Add missing property alias "animation" in Slider Plasma Component
>
> Item now matches it's own documentation.
>
>
> Diffs
> -----
>
> plasma/declarativeimports/plasmacomponents/qml/Slider.qml 447dbb1
>
> Diff: http://git.reviewboard.kde.org/r/104318/diff/
>
>
> Testing
> -------
>
> Tested in Component Gallery (which didn't work before!)
>
>
> Thanks,
>
> David Edmundson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120319/68056c10/attachment-0001.html>
More information about the Plasma-devel
mailing list