Review Request: Add missing property alias "animation" in Slider Plasma Component

Aaron J. Seigo aseigo at kde.org
Sun Mar 18 19:57:48 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104318/#review11571
-----------------------------------------------------------


what is the use case for knowing if it is animated or not? this seems like an internal implementation detail?

- Aaron J. Seigo


On March 17, 2012, 7:27 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104318/
> -----------------------------------------------------------
> 
> (Updated March 17, 2012, 7:27 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Add missing property alias "animation" in Slider Plasma Component
> 
> Item now matches it's own documentation.
> 
> 
> Diffs
> -----
> 
>   plasma/declarativeimports/plasmacomponents/qml/Slider.qml 447dbb1 
> 
> Diff: http://git.reviewboard.kde.org/r/104318/diff/
> 
> 
> Testing
> -------
> 
> Tested in Component Gallery (which didn't work before!) 
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120318/e2432e56/attachment-0001.html>


More information about the Plasma-devel mailing list