Review Request: add public slot FolderView::addUrl(KUrl)

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104328/#review11570
-----------------------------------------------------------


this at least allows it to be implemented in a containment-specific way. however this still feels "wrong", though certainly less wrong than the previous appraoches :) what does "adding a url" really mean? and what if multiple urls are to be "added"? this is almost identical to the drag and drop process, at least once it has been determined that they drop target is the containment. in Plasma::Wallpaper there is a void addUrls(const KUrl::List &urls); slot which is probably the signature to mimic at least for consistency. it also seems like a good idea to have a bool return so that the containment can say whether or not it successfully added the URLs (if not, then perhaps the processing should be passed elsewhere; would also allow a default implementation in Plasma::Containment which always returns false triggering the existing current behaviour?). this will need to end up being integrated into ContainmentPrivate::dropData for consistency i think.


plasma/applets/folderview/folderview.h
<http://git.reviewboard.kde.org/r/104328/#comment9190>

    should be a const reference. (const KUrl &url)


- Aaron J. Seigo


On March 18, 2012, 6:40 a.m., Ignat Semenov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104328/
> -----------------------------------------------------------
> 
> (Updated March 18, 2012, 6:40 a.m.)
> 
> 
> Review request for Plasma, Aaron J. Seigo, Marco Martin, and Fredrik Höglund.
> 
> 
> Description
> -------
> 
> add public slot FolderView::addUrl(KUrl)
>     
> This slot can be used e.g. by Kickoff for the "Add to Desktop" action to add a real link instead of an Icon applet.
> 
> 
> Diffs
> -----
> 
>   plasma/applets/folderview/folderview.h 4e441eb 
>   plasma/applets/folderview/folderview.cpp 121d1e7 
> 
> Diff: http://git.reviewboard.kde.org/r/104328/diff/
> 
> 
> Testing
> -------
> 
> Tested, works.
> 
> 
> Thanks,
> 
> Ignat Semenov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120318/bba0589e/attachment.html>