Review Request: Fix padding in ToolButton and TabButton

Marco Martin notmart at gmail.com
Sat Mar 17 20:12:59 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104319/#review11509
-----------------------------------------------------------

Ship it!


Ship It!

- Marco Martin


On March 17, 2012, 7:44 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104319/
> -----------------------------------------------------------
> 
> (Updated March 17, 2012, 7:44 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Fix padding in ToolButton and TabButton between icon and text.
> 
> This also brings it in line with the regular button which is done properly.
> 
> 
> Diffs
> -----
> 
>   plasma/declarativeimports/plasmacomponents/qml/TabButton.qml dc8d34a 
>   plasma/declarativeimports/plasmacomponents/qml/ToolButton.qml 0907a22 
> 
> Diff: http://git.reviewboard.kde.org/r/104319/diff/
> 
> 
> Testing
> -------
> 
> Opened in Gallery.
> 
> 
> Screenshots
> -----------
> 
> Tab Before
>   http://git.reviewboard.kde.org/r/104319/s/473/
> Tab After
>   http://git.reviewboard.kde.org/r/104319/s/474/
> ToolButton Before
>   http://git.reviewboard.kde.org/r/104319/s/475/
> ToolButton After
>   http://git.reviewboard.kde.org/r/104319/s/477/
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120317/c350b404/attachment.html>


More information about the Plasma-devel mailing list