Review Request: do not crash when passing a url in the ctor e.g. when creating a folderview by dropping a folder onto the desktop

[Fredrik Höglund]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104311/#review11504
-----------------------------------------------------------

Ship it!


Ship It!

- Fredrik Höglund


On March 17, 2012, 9:52 a.m., Ignat Semenov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104311/
> -----------------------------------------------------------
> 
> (Updated March 17, 2012, 9:52 a.m.)
> 
> 
> Review request for Plasma, Aaron J. Seigo, Marco Martin, and Fredrik Höglund.
> 
> 
> Description
> -------
> 
> Do not call setUrl in the ctor since m_dirLister does not exist yet. Instead, assign m_url in the ctor and call setUrl later in init().
> 
> 
> Diffs
> -----
> 
>   plasma/applets/folderview/folderview.cpp a94ce87 
> 
> Diff: http://git.reviewboard.kde.org/r/104311/diff/
> 
> 
> Testing
> -------
> 
> Tested, works.
> 
> Would be nice to give the code a static analyzer run, if there was a decent static analyzer available in Linux. Anybody have relevant experience?
> 
> 
> Thanks,
> 
> Ignat Semenov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120317/71c80e58/attachment.html>