request for review

[Aaron J. Seigo]

On Friday, March 16, 2012 13:10:54 Shaun Reich wrote:
> i do have a question however, as to why matches get triggered (even
> for the mediawiki engine which currently resides in there, afict),
> even though it isn't in singlerunnermode, and the prefix isn't being
> hit. e.g. user is typing in "some query" would trigger a match for
> that runner, instead of it only being triggered by "wiki some query".
> any ideas on that?

because RunnerManager does not know anything about prefixes :)

with the RunnerSyntax there is a step in a useful direction there, but then 
there still needs to be a way saying "this runner only cares when the prefixes 
match" (some do both prefix matching and free text search)

in my testing (admitedly some time ago) there was very little benefit to doing 
this in RunnerManager however versus just letting the runners themselves figure 
it out.

.. assuming i'm understanding what you're asking :)

-- 
Aaron J. Seigo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120316/d69bc971/attachment.sig>