Review Request: Rename window deocration "Laptop" to "Minimal"

Thomas Lübking thomas.luebking at web.de
Thu Mar 15 12:16:00 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104282/#review11428
-----------------------------------------------------------


"Leightweight"? - "Minimal" is generic and could just as well read "minimal functionality" or stuff.
About the comment: why not paint it directly into the preview? If you write a tldr; novel into a tooltip, that's not gonna help either.

- Thomas Lübking


On March 15, 2012, 7:28 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104282/
> -----------------------------------------------------------
> 
> (Updated March 15, 2012, 7:28 a.m.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Description
> -------
> 
> The window decoration Laptop is kept for legacy or thin client
> setups. To make this more clear the decoration is renamed. In
> order to make the transition easier only the name is changed,
> while library name is untouched.
> 
> Additionally a comment is added which should be shown in the
> user interface (requires bug #296041 to be implemented).
> 
> 
> Diffs
> -----
> 
>   kwin/clients/laptop/laptop.desktop ccc9d54 
>   kwin/clients/laptop/laptopclient.cpp 52efcd1 
> 
> Diff: http://git.reviewboard.kde.org/r/104282/diff/
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> Renamed decoration
>   http://git.reviewboard.kde.org/r/104282/s/465/
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120315/face13df/attachment.html>


More information about the Plasma-devel mailing list