Review Request: Merge the final and fixed QML battery monitor to master.
Viranch Mehta
viranch.mehta at gmail.com
Tue Mar 13 09:51:46 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104226/
-----------------------------------------------------------
(Updated March 13, 2012, 9:51 a.m.)
Review request for Plasma.
Changes
-------
Temporarily remove i18n() for complex strings
Alias plasmoid.rootItem.pmSource to pmSource
Implement powermanagement enabled/disabled
Make setScreenBrightness service job return void
Description
-------
I fixed the QML battery monitor to be fairly usable and this diff merges it to master.
Diffs (updated)
-----
plasma/generic/applets/CMakeLists.txt 2dedcb2
plasma/generic/applets/batterymonitor/CMakeLists.txt PRE-CREATION
plasma/generic/applets/batterymonitor/Messages.sh PRE-CREATION
plasma/generic/applets/batterymonitor/README.txt PRE-CREATION
plasma/generic/applets/batterymonitor/battery-oxygen-inkscape.svgz PRE-CREATION
plasma/generic/applets/batterymonitor/battery-oxygen.svgz PRE-CREATION
plasma/generic/applets/batterymonitor/contents/config/main.xml PRE-CREATION
plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml PRE-CREATION
plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml PRE-CREATION
plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml PRE-CREATION
plasma/generic/applets/batterymonitor/contents/ui/config.ui PRE-CREATION
plasma/generic/applets/batterymonitor/metadata.desktop PRE-CREATION
plasma/generic/dataengines/powermanagement/powermanagementengine.h 20642c2
plasma/generic/dataengines/powermanagement/powermanagementengine.cpp 5572fcb
plasma/generic/dataengines/powermanagement/powermanagementjob.h 2c32015
plasma/generic/dataengines/powermanagement/powermanagementjob.cpp e205bb0
plasma/generic/dataengines/powermanagement/powermanagementservice.operations ad1301f
Diff: http://git.reviewboard.kde.org/r/104226/diff/
Testing
-------
Applet and dataengine both tested and work fine.
Thanks,
Viranch Mehta
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120313/dbfe91b0/attachment.html>
More information about the Plasma-devel
mailing list