Review Request: Make thumbnail size configurable and tell KIO to use all thumbnailer plguins

Shantanu Tushar Jha shaan7in at gmail.com
Sun Mar 11 16:51:36 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104229/
-----------------------------------------------------------

Review request for Plasma and Marco Martin.


Description
-------

This patch makes two additions-
1. Thumbnail size is hardcoded into metadatamodel, this patch adds a property to make it configurable
2. KIO Thumbnailer uses a default set of plugins (from global config, which can't be set from PA) which doesn't include video thumbnailers for example. This makes metadatamodel fail when its asked for a thumbnail for a video file. This patch explicitly tells KIO to use all plugins.


Diffs
-----

  components/metadatamodel/metadatamodel.h 85750fe 
  components/metadatamodel/metadatamodel.cpp 74ad09c 

Diff: http://git.reviewboard.kde.org/r/104229/diff/


Testing
-------

Both features work when tested from QML and don't seem to have any side-effects.


Thanks,

Shantanu Tushar Jha

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120311/3b389986/attachment.html>


More information about the Plasma-devel mailing list