Review Request: Faster Implementation of AbstractMetadataModel::propertyUrl

Commit Hook null at kde.org
Wed Mar 7 09:51:27 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104172/#review11188
-----------------------------------------------------------


This review has been submitted with commit d3040600921ef49d39c6907a9b19d99e10c9d9c9 by Vishesh Handa to branch master.

- Commit Hook


On March 6, 2012, 4:28 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104172/
> -----------------------------------------------------------
> 
> (Updated March 6, 2012, 4:28 p.m.)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Description
> -------
> 
> Use a hash to store all the abbreviations. It provides faster lookups.
> 
> 
> Diffs
> -----
> 
>   components/metadatamodel/CMakeLists.txt a10978b 
>   components/metadatamodel/abstractmetadatamodel.h e973ccf 
> 
> Diff: http://git.reviewboard.kde.org/r/104172/diff/
> 
> 
> Testing
> -------
> 
> Nope. I have no idea how to test this. I'm just reviewing the code.
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120307/b44632ba/attachment.html>


More information about the Plasma-devel mailing list