Review Request: Faster Implementation of AbstractMetadataModel::propertyUrl
Marco Martin
notmart at gmail.com
Wed Mar 7 09:27:14 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104172/#review11187
-----------------------------------------------------------
Ship it!
very appreciated ;)
- Marco Martin
On March 6, 2012, 4:28 p.m., Vishesh Handa wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104172/
> -----------------------------------------------------------
>
> (Updated March 6, 2012, 4:28 p.m.)
>
>
> Review request for Plasma and Marco Martin.
>
>
> Description
> -------
>
> Use a hash to store all the abbreviations. It provides faster lookups.
>
>
> Diffs
> -----
>
> components/metadatamodel/CMakeLists.txt a10978b
> components/metadatamodel/abstractmetadatamodel.h e973ccf
>
> Diff: http://git.reviewboard.kde.org/r/104172/diff/
>
>
> Testing
> -------
>
> Nope. I have no idea how to test this. I'm just reviewing the code.
>
>
> Thanks,
>
> Vishesh Handa
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120307/9a531354/attachment.html>
More information about the Plasma-devel
mailing list