Review Request: ksysguard.deskstop shoud not use generic name "System Monitor" for its "Name" key

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105338/#review15251
-----------------------------------------------------------


This review has been submitted with commit 1bfb808d454312e46436adad5bbcd143e68cbeee by Jekyll Wu to branch master.

- Commit Hook


On June 24, 2012, 7:39 a.m., Jekyll Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105338/
> -----------------------------------------------------------
> 
> (Updated June 24, 2012, 7:39 a.m.)
> 
> 
> Review request for Plasma and John Tapsell.
> 
> 
> Description
> -------
> 
> Currently, ksysguard.desktop contains "Name=System Monitor" and "GenericName=System Monitor". 
> 
> FOD specification[1] writes:
> 
>     Name        Specific name of the application, for example "Mozilla".
>     GenericName Generic name of the application, for example "Web Browser".
> 
> So I think using a generic name like "System Monitor" for "Name" is problematic. The current situation of using the same generic name for both "Name" and "GenericName" is also questionable.
> 
> The patch simply uses "KSysGuard" for the "Name" key . 
> 
> [1] http://standards.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html#recognized-keys
> 
> 
> Diffs
> -----
> 
>   ksysguard/gui/ksysguard.desktop 7e8ff32 
> 
> Diff: http://git.reviewboard.kde.org/r/105338/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jekyll Wu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120629/d06f85fa/attachment.html>