Review Request: Plasma qml-Components ToolButton: change text-color on hover more fluently
Johannes Tröscher
fritz_van_tom at hotmail.com
Thu Jun 28 21:21:32 UTC 2012
> On June 28, 2012, 4:58 p.m., Aaron J. Seigo wrote:
> > Ship It!
>
> Johannes Tröscher wrote:
> i'm not that experienced with git.. i've pushed it to master, could you backport it to 4.9? i don't know how to push single commits
>
> Greg T wrote:
> I suggest you to use 'git cherry-pick' for that task.
thanks, submitted
- Johannes
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105375/#review15231
-----------------------------------------------------------
On June 28, 2012, 3:40 p.m., Johannes Tröscher wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105375/
> -----------------------------------------------------------
>
> (Updated June 28, 2012, 3:40 p.m.)
>
>
> Review request for Plasma and Aaron J. Seigo.
>
>
> Description
> -------
>
> this is mostly visible with dark-themes only.
> as of now the text color got only changed when the "hover-element" was fully visible. this looked a bit weird.
> this patch adds a ColorAnimation with the same duration as the opacity-animation on the "hover-element" as Behavior for the Label.
> now the color changes fluently on hovering the ToolButton
>
>
> Diffs
> -----
>
> plasma/declarativeimports/plasmacomponents/qml/ToolButton.qml 1655821
>
> Diff: http://git.reviewboard.kde.org/r/105375/diff/
>
>
> Testing
> -------
>
> tested, works
>
>
> Thanks,
>
> Johannes Tröscher
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120628/f10250aa/attachment.html>
More information about the Plasma-devel
mailing list