Review Request: DBus-interface for changing wallpapers

Varun Herale varun.herale at gmail.com
Sun Jun 24 15:47:10 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105319/
-----------------------------------------------------------

(Updated June 24, 2012, 3:47 p.m.)


Review request for Plasma.


Changes
-------

Changed the code accordingly :)

In case of "Slideshow", it doesn't append the image in any case. Will raise a bug and check that.


Description
-------

This patch is for hosting a dbus-interface that can be used to load any installed wallpaper plugin onto current desktop containment. In case of default "image" plugin, the path to the image can also be sent which will change the wallpaper.  


Diffs (updated)
-----

  plasma/desktop/shell/dbus/org.kde.plasma.App.xml eefce32 
  plasma/desktop/shell/plasmaapp.h 6ae0c89 
  plasma/desktop/shell/plasmaapp.cpp 7abd8fc 

Diff: http://git.reviewboard.kde.org/r/105319/diff/


Testing
-------

Tested on different activities and made sure it works for per-virtual desktop containment.

Haven't tested on a system with multiple screens though, as I don't have access to one. Could someone please test for that ?


Thanks,

Varun Herale

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120624/2c8b1d4a/attachment.html>


More information about the Plasma-devel mailing list