Review Request: fixed widget explorer or activity manager not closed when clicking desktop area above panel

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105340/#review15061
-----------------------------------------------------------



plasma/desktop/shell/controllerwindow.cpp
<http://git.reviewboard.kde.org/r/105340/#comment11848>

    don't commit commented out debug code.



plasma/desktop/shell/controllerwindow.cpp
<http://git.reviewboard.kde.org/r/105340/#comment11849>

    What's the need for the timer?
    
    deleteLater(); already deletes the object once we've processed everything the event queue (the 'later') so as I see this it does the same thing twice.
    
    If there is a reason, document it!


- David Edmundson


On June 24, 2012, 1:45 p.m., Reza Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105340/
> -----------------------------------------------------------
> 
> (Updated June 24, 2012, 1:45 p.m.)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Description
> -------
> 
> There is a bug which prevent widget explorer or activity manager not closed when clicking desktop area above panel.
> 
> Steps to reproduce:
> - after login and with no window appear (we can see desktop area clearly).
> - open widget explorer from panel
> - then click at desktop area somewhere above the panel.
> 
> The expected result is widget explorer or activity manager will be closed.
> 
> 
> Diffs
> -----
> 
>   plasma/desktop/shell/controllerwindow.cpp 5e5c26f 
> 
> Diff: http://git.reviewboard.kde.org/r/105340/diff/
> 
> 
> Testing
> -------
> 
> test against master branch.
> 
> 
> Thanks,
> 
> Reza Shah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120624/4edf2677/attachment.html>