Review Request: ksysguard.deskstop shoud not use generic name "System Monitor" for its "Name" key

Jekyll Wu adaptee at gmail.com
Sun Jun 24 07:39:18 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105338/
-----------------------------------------------------------

Review request for Plasma and John Tapsell.


Description
-------

Currently, ksysguard.desktop contains "Name=System Monitor" and "GenericName=System Monitor". 

FOD specification[1] writes:

    Name        Specific name of the application, for example "Mozilla".
    GenericName Generic name of the application, for example "Web Browser".

So I think using a generic name like "System Monitor" for "Name" is problematic. The current situation of using the same generic name for both "Name" and "GenericName" is also questionable.

The patch simply uses "KSysGuard" for the "Name" key . 

[1] http://standards.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html#recognized-keys


Diffs
-----

  ksysguard/gui/ksysguard.desktop 7e8ff32 

Diff: http://git.reviewboard.kde.org/r/105338/diff/


Testing
-------


Thanks,

Jekyll Wu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120624/0f9961bd/attachment.html>


More information about the Plasma-devel mailing list