Review Request: Add missing email addresses back into add widget tooltip.

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105312/#review15051
-----------------------------------------------------------


The reason the link doesn't work is that by default QML label links do nothing but emit a signal when clicked

in the label add:

    onLinkActivated: {
        plasmoid.openUrl(link);
    }




libs/plasmagenericshell/widgetsexplorer/plasmaappletitemmodel_p.h
<http://git.reviewboard.kde.org/r/105312/#comment11836>

    Good spot!


- David Edmundson


On June 21, 2012, 4:39 a.m., Matthew John Dawson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105312/
> -----------------------------------------------------------
> 
> (Updated June 21, 2012, 4:39 a.m.)
> 
> 
> Review request for Plasma, Ivan Čukić and Marco Martin.
> 
> 
> Description
> -------
> 
> When the QML port of the add widget dialog occured, the creator's email address got chopped off.  This commit fixes a bug hidding the email address, and also starts displaying it again in the tooltip.
> 
> There are a couple of issue left with this patch:
> 1) I have to disable wrapping, otherwise the text wraps at odd points for no reason (it fits fine otherwise).
> 2) The link currently doesn't work as I'm not sure how to hook it up to send mail.  Should it be left as is, or just remove the link for 4.9 and update with a link for 4.10?
> 
> 
> Diffs
> -----
> 
>   libs/plasmagenericshell/widgetsexplorer/package/contents/ui/Tooltip.qml ba804fd006496ee4a7118e97fe44038f0617eec7 
>   libs/plasmagenericshell/widgetsexplorer/plasmaappletitemmodel_p.h e745ef58533ab0e22d2109d5beeff6c29c4d18b4 
> 
> Diff: http://git.reviewboard.kde.org/r/105312/diff/
> 
> 
> Testing
> -------
> 
> Tested locally in Xephyr.  The tooltip now contains the email address.
> 
> 
> Thanks,
> 
> Matthew John Dawson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120624/1670eafe/attachment-0001.html>