Review Request: Use common plasma components Tooltip in battery monitor

[Viranch Mehta]

> On June 18, 2012, 3:37 p.m., Viranch Mehta wrote:
> > The button size and the hover appearance is different from the original one. The IconButton component was made to keep the look of the buttons consistent with the original version of the applet. Do we want to change this?
> 
> David Edmundson wrote:
>     Valid argument for now, won't be valid when everything moves to QML/Plasma Components.
>     
>     You're maintainer, you have final say.
>     If you want me to wait till 4.10 when more applets are QML based I will do.
> 
> Viranch Mehta wrote:
>     Well after a second thought, I think its a better idea to use plasma components for consistency over plasma rather than maintaining consistency with previous versions. but the original button for some reason looks *really* better in visual terms to me (in fact, the button is also used in some other plasmoids including the network manager). so...
>     
>     to plasma components dev: can we have an option in the button of what background svg is used? may be a switch between the current one and the one in this plasmoid (widgets/viewitem)?
>     
>     if that may take time to come up, or is not desired, we can have this patch shipped right in!

david, please ship this patch for now. thanks!


- Viranch


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105283/#review14839
-----------------------------------------------------------


On June 17, 2012, 7:52 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105283/
> -----------------------------------------------------------
> 
> (Updated June 17, 2012, 7:52 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Current battery monitor implements it's own Button class, this previously broke styles with theme text and overloads icon sizes and such.
> 
> It's bad for applets to implement their own version of common classes as it prevents consistency.
> 
> (will fix the whitespace addition before commit)
> 
> 
> Diffs
> -----
> 
>   plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml d4454c6 
>   plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml a2ab72a 
> 
> Diff: http://git.reviewboard.kde.org/r/105283/diff/
> 
> 
> Testing
> -------
> 
> Checked applet looked ok.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120621/36b537f9/attachment-0001.html>