Review Request: improve/add keyboard navigation in kickoff-qml (mystery included)

[Greg T]

> On June 10, 2012, 7:56 a.m., Martin Gräßlin wrote:
> > cool, thanks for taking up where I left the work. I appreciate that very much.
> > 
> > I have no idea about the key handling issue. I will try to test out the branch next week and play with it.
> > 
> > As everything is in a branch, I'm fine if you develop in it without review requests, though if you want to get the feedback you are of course welcome to open a request.

Alright, I have figured it out for myself. :) With my latest commit keyboard navigation should be fine. You are welcome to test and review it.


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105196/#review14571
-----------------------------------------------------------


On June 9, 2012, 12:32 p.m., Greg T wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105196/
> -----------------------------------------------------------
> 
> (Updated June 9, 2012, 12:32 p.m.)
> 
> 
> Review request for Plasma and Martin Gräßlin.
> 
> 
> Description
> -------
> 
> since qml is my new hobby I'm trying to work on some little projects ;). Well, this is a first step towards adding usable keyboard navigation to kickoff. Big problem: Somehow the Key_Left keypress event gets swallowed. You are supposed to control the tabbar by hitting left and right arrow key, just as with c++ kickoff. atm you can just go to the right. any help on debugging this issue is really appreciated.
> 
> 
> Diffs
> -----
> 
>   plasma/desktop/applets/kickoff/package/contents/ui/KickoffItem.qml 919e6f7 
>   plasma/desktop/applets/kickoff/package/contents/ui/MainView.qml 7fc9d2b 
>   plasma/desktop/applets/kickoff/package/contents/ui/kickoff.qml 4a9a5e6 
> 
> Diff: http://git.reviewboard.kde.org/r/105196/diff/
> 
> 
> Testing
> -------
> 
> kinda works
> 
> 
> Thanks,
> 
> Greg T
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120618/ae56db8e/attachment-0001.html>