Review Request: Add a keyboard shortcut to stop the current activity

Marco Martin notmart at gmail.com
Sun Jun 17 20:34:34 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105279/#review14815
-----------------------------------------------------------

Ship it!


well, ship it but not now ;)
should be indeed when master opens again, but the patch is fine

- Marco Martin


On June 16, 2012, 11:39 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105279/
> -----------------------------------------------------------
> 
> (Updated June 16, 2012, 11:39 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Add a keyboard shortcut to stop the current activity. This was suggested at the KDE Workspace sprint in order to improve workflow.
> 
> Intend to merge into 4.10 after freeze not 4.9. Also happy to discuss alternate default key shortcuts. 
> 
> 
> This addresses bug 302003.
>     http://bugs.kde.org/show_bug.cgi?id=302003
> 
> 
> Diffs
> -----
> 
>   plasma/desktop/shell/desktopcorona.h df111b2 
>   plasma/desktop/shell/desktopcorona.cpp c7f3eec 
> 
> Diff: http://git.reviewboard.kde.org/r/105279/diff/
> 
> 
> Testing
> -------
> 
> Pressed shortcut, tested current activity closed, and that I could not close the last activity.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120617/79df3f36/attachment.html>


More information about the Plasma-devel mailing list