Review Request: Support for multiple batteries in battery monitor applet

[David Edmundson]

> On June 16, 2012, 6:40 p.m., Marco Martin wrote:
> > i think the change is on the right path, but should wait for the unfreeze, since is not a "trivial" fix

Given this patch is untested (due to Viranch having only one battery) and that we will have a lot of angry users complaining that the feature is missing, can I suggest we submit a version with this patch to kde-look.org, so that it is available in "get new stuff".

This will give us the extra testing before we merge in 4.10, and at least provide a workaround we can share for those users, and the people giving support.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105277/#review14800
-----------------------------------------------------------


On June 16, 2012, 3:25 p.m., Viranch Mehta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105277/
> -----------------------------------------------------------
> 
> (Updated June 16, 2012, 3:25 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> This patch implements support for computers with multiple batteries in the battery monitor applet.
> 
> I'm not sure if I should push it now or after the unfreeze. This review addresses the bug #301533
> 
> 
> This addresses bug 301533.
>     http://bugs.kde.org/show_bug.cgi?id=301533
> 
> 
> Diffs
> -----
> 
>   plasma/generic/applets/batterymonitor/contents/code/logic.js PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml a2ab72a 
>   plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml 08a46ec 
> 
> Diff: http://git.reviewboard.kde.org/r/105277/diff/
> 
> 
> Testing
> -------
> 
> Added dummy battery sources in power management engine and tested with it. Works fine, as expected with such sources.
> 
> Can someone with multiple batteries please test the patch? since I don't have a computer with multiple batteries.
> 
> 
> Thanks,
> 
> Viranch Mehta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120617/b1875d6e/attachment.html>