Review Request: Support for multiple batteries in battery monitor applet

Viranch Mehta viranch.mehta at gmail.com
Sat Jun 16 15:25:16 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105277/
-----------------------------------------------------------

Review request for Plasma.


Description
-------

This patch implements support for computers with multiple batteries in the battery monitor applet.

I'm not sure if I should push it now or after the unfreeze. This review addresses the bug #301533


This addresses bug 301533.
    http://bugs.kde.org/show_bug.cgi?id=301533


Diffs
-----

  plasma/generic/applets/batterymonitor/contents/code/logic.js PRE-CREATION 
  plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml a2ab72a 
  plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml 08a46ec 

Diff: http://git.reviewboard.kde.org/r/105277/diff/


Testing
-------

Added dummy battery sources in power management engine and tested with it. Works fine, as expected with such sources.

Can someone with multiple batteries please test the patch? since I don't have a computer with multiple batteries.


Thanks,

Viranch Mehta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120616/61e01bd4/attachment.html>


More information about the Plasma-devel mailing list