Review Request: Make sure vertical slider's handle have the same shadow as the horizontal one

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105269/#review14781
-----------------------------------------------------------

Ship it!


for now this patch already makes things a bit better, so +1.

however, i think the proper solution that should be done is not using rotations at all, but handle the vertical/horizontal case more separately, even tough it leads to a more complicate code

- Marco Martin


On June 16, 2012, 12:23 a.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105269/
> -----------------------------------------------------------
> 
> (Updated June 16, 2012, 12:23 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> The vertical sliders are rotated horizontal sliders including all the light effects, which looks bad as it appears like there are two different light sources. This patch rotates back the slider handle, so all the handles have consistent shadowing. The grooves should also have consistent shadow, but that may come in later patch (also it's way less visible).
> 
> See screenshots.
> 
> 
> Diffs
> -----
> 
>   plasma/declarativeimports/plasmacomponents/qml/Slider.qml 5867164 
> 
> Diff: http://git.reviewboard.kde.org/r/105269/diff/
> 
> 
> Testing
> -------
> 
> Tested on widget gallery.
> 
> 
> Screenshots
> -----------
> 
> Before
>   http://git.reviewboard.kde.org/r/105269/s/603/
> After
>   http://git.reviewboard.kde.org/r/105269/s/604/
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120616/a6812c08/attachment.html>