Review Request: Make sure vertical slider's handle have the same shadow as the horizontal one

Martin Klapetek martin.klapetek at gmail.com
Sat Jun 16 00:23:35 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105269/
-----------------------------------------------------------

(Updated June 16, 2012, 12:23 a.m.)


Review request for Plasma.


Changes
-------

Sorry for the wrong patch, it's really late night here. Now it's ok.


Description
-------

The vertical sliders are rotated horizontal sliders including all the light effects, which looks bad as it appears like there are two different light sources. This patch rotates back the slider handle, so all the handles have consistent shadowing. The grooves should also have consistent shadow, but that may come in later patch (also it's way less visible).

See screenshots.


Diffs (updated)
-----

  plasma/declarativeimports/plasmacomponents/qml/Slider.qml 5867164 

Diff: http://git.reviewboard.kde.org/r/105269/diff/


Testing
-------

Tested on widget gallery.


Screenshots
-----------

Before
  http://git.reviewboard.kde.org/r/105269/s/603/
After
  http://git.reviewboard.kde.org/r/105269/s/604/


Thanks,

Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120616/d50de73a/attachment-0001.html>


More information about the Plasma-devel mailing list