Review Request: Plasm qml-components: also highlight the dualstate button on keyboard-focus

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105232/#review14727
-----------------------------------------------------------



plasma/declarativeimports/plasmacomponents/qml/private/DualStateButton.qml
<http://git.reviewboard.kde.org/r/105232/#comment11626>

    loos like this will work but i dislike how shadowLoader.state is being set all over the place in a rather procedural manner. much nicer imho would be sth like:
    
    Loader {
        id: shadowLoader
        anchors.fill: surfaceLoader
        state: (duableButton.enabled && dualButton.focus) ? "hover" : "shadow"
    }
    
    and then do the right thing in Keys.onSpacePressed, Keys.onReturnPressed, etc.
    
    this would also get rid of the entered() function and maybe even clean up the MouseArea below as well.
    
    to me this would just feel "more QML"
    
    Marco: what do you think?


- Aaron J. Seigo


On June 12, 2012, 10:25 p.m., Johannes Tröscher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105232/
> -----------------------------------------------------------
> 
> (Updated June 12, 2012, 10:25 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> this will enable the highlight on a dualstatebutton (like a checkbox) also if the button has keyboardfocus.
> 
> 
> Diffs
> -----
> 
>   plasma/declarativeimports/plasmacomponents/qml/private/DualStateButton.qml 1579e88 
> 
> Diff: http://git.reviewboard.kde.org/r/105232/diff/
> 
> 
> Testing
> -------
> 
> tested, works
> 
> 
> Thanks,
> 
> Johannes Tröscher
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120614/44f2284b/attachment.html>