Review Request: Plasmate: when "Enable signing plasmoid" is enabled, automatically choose a key
Aaron J. Seigo
aseigo at kde.org
Thu Jun 14 10:13:41 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105074/#review14725
-----------------------------------------------------------
Ship it!
Ship It!
- Aaron J. Seigo
On June 12, 2012, 11:44 a.m., Giorgos Tsiapaliwkas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105074/
> -----------------------------------------------------------
>
> (Updated June 12, 2012, 11:44 a.m.)
>
>
> Review request for Plasma, Sebastian Kügler and Aaron J. Seigo.
>
>
> Description
> -------
>
> Hello,
>
> right now when "Enable signing plasmoid" is enabled if the user doesn't choose a gpg key,
> plasmate won't have a key enabled. So "Enable signing plasmoid", will be enabled but no signing will
> happen.
>
> How to test the issue,
> - rm ${KDEHOME}/share/config/plasmaterc
> -create a gpg key(gpg --gen-key)
> -open plasmate
> -click publisher
> -click enable
>
>
> Diffs
> -----
>
> publisher/signingwidget.h 501752e
> publisher/signingwidget.cpp e63dbbd
>
> Diff: http://git.reviewboard.kde.org/r/105074/diff/
>
>
> Testing
> -------
>
> It works.
>
>
> Thanks,
>
> Giorgos Tsiapaliwkas
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120614/e86a2d65/attachment.html>
More information about the Plasma-devel
mailing list